Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: duplicated sdk #69

Closed
wants to merge 2 commits into from
Closed

chore: duplicated sdk #69

wants to merge 2 commits into from

Conversation

agualis
Copy link
Collaborator

@agualis agualis commented Oct 16, 2024

b-sdk was declared twice. Keep the lib dependency and remove the frontend-v3 one.

TODO: remove other duplicated dependencies.

Copy link

vercel bot commented Oct 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
mono-frontend-v3 ❌ Failed (Inspect) Oct 16, 2024 7:43am
mono-test-v3 ❌ Failed (Inspect) Oct 16, 2024 7:43am

@agualis
Copy link
Collaborator Author

agualis commented Oct 16, 2024

Closing because it seems to be that best practice in turborepo is to install in each package/app where it's needed: https://turbo.build/repo/docs/crafting-your-repository/managing-dependencies

Enhanced flexibility: In a monorepo at scale, it can be unrealistic to expect each package to use the same version of an external dependency. When there are many teams working in the same codebase, there will be differing priorities, timelines, and needs due to the realities of operating at scale. By installing dependencies in the package that uses them, you can enable your ui team to bump to the latest version of TypeScript, while your web team can prioritize shipping new features and bumping TypeScript later. Additionally, if you still want to keep dependency versions in sync, you can do that, too.

@agualis agualis closed this Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant